[Lunar-commits] <moonbase> xfce4-session: tweak the depends a bit.

[Auke Kok]

On Tue, Jun 19, 2012 at 11:33:37PM +0200, v4hn wrote:
> On Tue, Jun 19, 2012 at 12:32:27PM -0400, Dennis Veatch wrote:
> > On 06/19/2012 12:17 PM, Auke Kok wrote:
> > >it's not OK, the lunar code will automatically ENABLE dependencies
> > >with empty $2/$3 if they are installed no matter what. After all,
> > >it has no way to DISABLE them for you anymore.
> 
> 
> _yes, I know_
> 
> 
> > >So, it may be ok from a source perspective, but from a lunar
> > >perspective, it's against the rules. I've repeated this logic
> > >problem a few times before on the list over the years.
> 
> link?
> 
> 
> > Thank you, that was my point and yes you have said this multiple times.
> > 
> > It is the reason I spent a great deal of time adding the
> > optional_depends stuff for kde and other modules that use
> > -DCMAKE_SOMEAPP=on or off.
> 
> 
> Yes, I know about this issue and I fixed quite a number of those
> mistakes myself. But in the case of xfce4-session there is no way to disable
> udisk/polkit/.. in the build process. Well you could strip the code files,
> but that's against the as-vanilla-as-possible rule.
> 
> 
> Do you suggest to write "--foobar" into $3 so you can disable it in the package management?
> The package will still be used if it will ever be installed anyway, so what's logical about that?

since they are so clearly <run>time-dependencies, and we have no way to handle
them properly, I would just *remove* them entirely, or include them from a
profile-only package such as the 'xfce4' shim. And yes, there you could indeed
add bogus --disable options.

Auke