lftp 3.4.6 build breaks, lftp 3.4.5 builds fine.

[Zbigniew Luszpinski]

> Take a look at the diff from the two versions,  see what changed
> around that the definitions for those classes.
>
> i'm away from my lunar box at the moment, so i can't really try myself
>
> Steve

Yep. I found it. This part of code is poorly written. It will break if there 
is no any crypto available (gnutls or openssl).  The lftp will break by 
default if there is no gnutls installed before. lftp can  be successfuly 
built without gnutls if openssl is installed and enabled with --with-openssl 
option. openssl support in lftp is disabled by default.

How to fix in lunar:

1. Add gnutls to lftp DEPENDS file
or
2. BUILD lftp script with ./configure --with-openssl and add openssl to lftp 
DEPENDS file
or
3. make script for lftp module which will check if gnutls or openssl modules 
are installed otherwise ask which one to install as dependency.

Wrong ways:
1. Rewrite lftp code (ugly hack)
2. ./configure --without-gnutls --without-openssl (breaks because lftp 
requires crypto for build process)

Choose the best way for lunar. In my opinion the 3rd one looks the best.
As a temporary solution I built lftp in this way:
lin --opts '--with-openssl' lftp

greetings,
Zbigniew 'zbiggy' Luszpinski

> On May 1, 2006, at 1:57 PM, Zbigniew Luszpinski wrote:
> >> lftp-3.4.6 compiles/installs perfectly here on a lunar box using
> >> kernel
> >> headers 2.4.x, gcc-3.4.5, glibc-2.3.6. Florin, who updated this
> >> module to
> >> lftp-3.4.6, is on a lunar box with kernel-headers 2.6.x, so your
> >> problem is
> >> not kernel related.
> >>
> >> Optimizations off doesn't mean much if the rest of your box (i.e.
> >> libs)
> >> were built with un-safe optimizations.
> >>
> >> Try adding "PSAFE=n" and/or "USE_WRAPPERS=n" to your lftp/DETAILS
> >> file and
> >> see if that makes a difference for you.
> >>
> >> Terry Chan
> >
> > Thanks for help. But still get the same results. It could be
> > problem of heavy
> > optimized libs if other builds would fail or previous lftp
> > compilation broke.
> > This problem appears with lftp 3.4.6 only.
> >
> > kernel headers  2.6
> > gcc 3.4.5
> > glibc 2.3.6
> >
> > greetings,
> > zbiggy
> >
> >> --------------------------------------------------------------------
> >>
> >> On Mon, May 01, 2006 at 11:11:56AM +0200, Zbigniew Luszpinski wrote:
> >>> Hi!
> >>>
> >>> The current, 3.4.6, lftp module is not compilable on my machine:
> >>> I checked this with all optimizations turned off. lin lftp
> >>>
> >>>         then mv -f ".deps/ftpclass.Tpo" ".deps/ftpclass.Plo";
> >>> else rm -f
> >>> ".deps/ftpclass.Tpo"; exit 1; fi
> >>> ftpclass.cc: In member function `virtual int Ftp::Do()':
> >>> ftpclass.cc:1333: error: 'class Ftp::Connection' has no member named
> >>> 'prot' make[1]: *** [ftpclass.lo] Error 1
> >>>
> >>> The previous lftp 3.4.5 builds fine:
> >>> lin -w 3.4.5 lftp
> >>>
> >>> Could somebody check lftp on other machine?
> >>>
> >>> greetings,
> >>> zbiggy
> >>
> >> _______________________________________________
> >> Lunar mailing list
> >> Lunar at lunar-linux.org
> >> http://foo-projects.org/mailman/listinfo/lunar
> >
> > _______________________________________________
> > Lunar mailing list
> > Lunar at lunar-linux.org
> > http://foo-projects.org/mailman/listinfo/lunar
>
> _______________________________________________
> Lunar mailing list
> Lunar at lunar-linux.org
> http://foo-projects.org/mailman/listinfo/lunar