Modules: amarok fix, kdenetwork3 fix, fxload, if2a, VisualBoyAdvance, jigloo

[Moritz Heiber]

On Thu, 13 Jan 2005 23:40:08 +0100
Alexandre Courbot <gnurou at gmail.com> wrote:

> > > - Slight fix on amarok. Can I also suggest it goes into kde3-apps
> > > (as does kaffeine, for instance)?
> > 
> > Hm .. did you have a look at the module I commited earlier?
> > Your 'fixed' module pretty much looks like the one I exported into
> > the moonbase ;-)
> 
> Doing another module (jigloo, I think), I've noticed that the
> 
> SOURCE_DIRECTORY=$BUILD_DIRECTORY/
> 
> line had the nasty side effect of deleting all the content of
> /usr/src. I think a couple of persons would be angry with it. I've
> also noticed that kdenetwork3 defined the SOURCE_DIRECTORY to be a
> subdir of BUILD_DIRECTORY, so this seemed a safe behavior to me.

You're absolutely right. Lunar is setting $SOURCE_DIRECTORY to
$BUILD_DIRECTORY/$MODULE-$VERSION by default. That is why you don't need
to define $SOURCE_DIRECTORY at all when your DETAILS file complies to
that scheme. However, $BUILD_DIRECTORY isn't right either. I just fixed
that. Must've been drunk or something.

Moving on to your new modules .. 

Regards,

Moritz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lunar-linux.org/pipermail/lunar/attachments/20050117/d7395c46/attachment.bin