[Lunar-commits] <moonbase> xfce4-session: tweak the depends a bit.

[Dennis Veatch]

On 06/19/2012 12:17 PM, Auke Kok wrote:
> On 06/19/2012 06:59 AM, v4hn wrote:
>> On Tue, Jun 05, 2012 at 05:39:51PM -0700, Auke Kok wrote:
>>> On 06/04/2012 09:47 AM, Florin Braescu wrote:
>>>> commit 1a70ca97729f1ad17b5d786f19b39cc35b8222b9
>>>> Author: Florin Braescu<florin at lunar-linux.org>
>>>> Date:   Mon Jun 4 18:47:07 2012 +0200
>>>> -optional_depends upower "" "--disable-upower" "Upower support"
>>>> -optional_depends ConsoleKit "" "--disable-consolekit" "ConsoleKit 
>>>> support"
>>>> -optional_depends polkit "" "--disable-polkit" "PolicyKit support"
>>>> -
>>>> -
>>>> +optional_depends upower     "" "" "Upower support"
>>>> +optional_depends ConsoleKit "" "" "ConsoleKit support"
>>>> +optional_depends polkit     "" "" "PolicyKit support"
>>>
>>> optional_depends without $2 and $3 are wrong, in almost all cases.
>>>
>>> why did you do this changge? do you realize how optional_depends
>>> works if $2 and $3 are empty?
>>
>> I just checked it:
>>
>> <<EOF
>> commit 12f6c4e533f419023d85a11a317158c8eff97fcb
>> Author: Nick Schermer<nick at xfce.org>
>> Date:   Sat Feb 25 10:53:06 2012 +0100
>>
>> Remove the consolekit, polkit, hal check.
>>
>> We only use consolekit over dbus, so no need to check things.
>> EOF
>>
>> Those are optional runtime dependencies, so it should be fine those
>> fields are left blank.
>
> it's not OK, the lunar code will automatically ENABLE dependencies 
> with empty $2/$3 if they are installed no matter what. After all, it 
> has no way to DISABLE them for you anymore.
>
> So, it may be ok from a source perspective, but from a lunar 
> perspective, it's against the rules. I've repeated this logic problem 
> a few times before on the list over the years.
>
> Auke
>

Thank you, that was my point and yes you have said this multiple times.

It is the reason I spent a great deal of time adding the 
optional_depends stuff for kde and other modules that use 
-DCMAKE_SOMEAPP=on or off.

> _______________________________________________
> Lunar-dev mailing list
> Lunar-dev at lunar-linux.org
> http://foo-projects.org/mailman/listinfo/lunar-dev
>