[Lunar-commits] <moonbase> amd-ucode: updated to 2012-01-17

[Auke Kok]

On 04/24/2012 01:55 PM, Zbigniew Luszpinski wrote:
>> On 03/14/2012 03:41 PM, Zbigniew Luszpinski wrote:
>>> commit ebec88418f9ee3e4430c7fd6271d21ef82c0af57
>>> Author: Zbigniew Luszpinski<zbiggy at lunar-linux.org>
>>> diff --git a/utils/amd-ucode/BUILD b/utils/amd-ucode/BUILD
>>> index 1b00727..b32a9c8 100644
>>> --- a/utils/amd-ucode/BUILD
>>> +++ b/utils/amd-ucode/BUILD
>>> @@ -1,7 +1,14 @@
>>>
>>>    (
>>>
>>> +   rm -f microcode_amd_solaris.bin*&&
>>> +   if [ ! -h /lib/firmware ]; then
>>> +      mkdir -p /usr/lib/firmware
>>> +      cp -a /lib/firmware/* /usr/lib/firmware/
>>> +      rm -rf /lib/firmware
>>> +      ln -sf /usr/lib/firmware /lib/firmware
>>> +   fi&&
>>
>> no, this is wrong, you should instead fix udev to use:
>>
>>     --with-firmware-path=/lib/firmware
>>
>> and then you can just drop the firmware in /lib/firmware.
>>
>> the change you did here breaks linux-firmware.
>
> Putting something except symlinks to /usr/lib in legacy /lib by modules is
> forbidden. If there are still modules which put something in /lib they
> should be fixed to /usr/lib.

moving files from other packages with `cp -a` in a BUILD is so far wrong 
that it violates all package rules.

period. no excuses.

>> the correct place for firmware is *still* /lib/firmware, and not
>> /usr/lib/firmware.
>>
>> Auke
>
> Thats weird. Show me any _current_ Linux datasheet/specs which says so.
> My Linux documentation says to use /usr/lib and provide a symlink to
> obsolete /lib for legacy applications. This way udev 182 and its friends
> were prepared by me and sent to dev ML. I still wait for acceptance of 2
> devs as we agreed few years ago for critical modules.
>
> Documentation and guidelines for Lunar developers: (you all devs should
> read this!)
> http://www.freedesktop.org/wiki/Software/systemd/TheCaseForTheUsrMerge
> Take a special look at Myth #4 and #7. In future Lunar I would like to
> have /usr with all distro content mounted by default read-only for
> security reasons. lin/lrm will be modified to do runtime remount read-
> write for install/remove time only.
>
> Human friendly information for humans/Lunar users:
> https://www.linux.com/news/featured-blogs/196-zonker/540696-the-ever-
> changing-linux-filesystems-merging-directoris-into-usr
>
> I hope you still remeber our aim to be the most Linux compatibile Linux
> distro.

don't take this personal. I'm all for unifying /usr/lib <-> /lib etc., 
after all, I'm directly involved with the systemd developers and support 
them with both code and advice.

but, until we actually do the merge, we need to stop breaking things.

and moreover, start focusing on making things like coreutils work in 
/usr/bin instead, which is far more worth your time than installing 
microcode. and zlib. and util-linux. and the lunar toolset....

Auke