[Lunar-bugs] [bug] non-default BUILD_DIRECTORY setting is not added to EXCLUDED file

[Arnald]

 Project:      lunar-linux
 Version:      <none>
 Component:    lunar (core tools)
 Category:     bug reports
 Priority:     critical
 Assigned to:  
 Reported by:  Arnald
 Updated by:   Arnald
 Status:       active

I am using a large external disk area to allow large builds eg. OOo.  I
do this by setting BUILD_DIRECTORY in /etc/lunar/local/config.  This
(incorrectly) does not add anything to /var/lib/linar/excluded, with
the result that installwatch adds the build directory to the list of
installed files, and they are deleted at the lrm stage and unavalable
for the lin stage - messy!

I had previously used a one liner in /etc/lunar/local/config, like:

grep -q ${BUILD_DIRECTORY} ${EXCLUDED} || echo ${BUILD_DIRECTORY} >>
${EXCLUDED}

and this has worked fine for about a year, until the recent changes to
lunar.  Now, whenever a lin lunar occurs, a fixed copy of
/var/lib/linar/excluded is copied over the existing one and therefore
the bug is reintroduced.  My fix has changed to accomodate the new
format for EXCLUDED:

if ! grep -q "${BUILD_DIRECTORY}" ${EXCLUDED} 
then
        echo "^${BUILD_DIRECTORY}/" >> ${EXCLUDED}
        message "${PROBLEM_COLOR} !!! Added ${BUILD_DIRECTORY} to
${EXCLUDED} !!!  {DEFAULT_COLOR}"
fi

and although this now fixes the bug in general, it suffers the
disadvantage that it does not work for the lunar module itself!

So, I still believe the fix I use is the correct one, the only question
is when to apply it.  My previous version was applied whenever any
lunar command executed, but you could make the case that, for example,
a lunar update is the correct time - I would disagree ;)  Perhaps a
more in-depth discussion is in order?

Anyway, hope this helps . . .

BTW I have labelled this as critical because it has become pointless to
do lunar updates until a fix is found.  In fact it is impossible to
install lunar properly at this time.


Arnald

-- 
View: http://lunar-linux.org/?q=node/view/303
Edit: http://lunar-linux.org/?q=project/comments/add/303