[Lunar Linux 0000418]: default_pre_build problems

[noreply at bugs.lunar-linux.org]

A BUGNOTE has been added to this bug.
=======================================================================
http://bugs.lunar-linux.org/view_bug_page.php?f_id=0000418
=======================================================================
Reporter:                   hardkrash
Handler:                    
=======================================================================
Project:                    Lunar Linux
Bug ID:                     0000418
Category:                   moonbase
Reproducibility:            always
Severity:                   tweak
Priority:                   low
Status:                     new
=======================================================================
Date Submitted:             2003-12-09 03:09 GMT
Last Modified:              2003-12-09 21:25 GMT
=======================================================================
Summary:                    default_pre_build problems
Description: 
We are porly handeling the unpacking of our sources in our moonbase
modules.  we need to clean up our act a bit.  to be able to use
KEEP_SOURCE properly

as i know it now linux isnt keeping its source nicely
=======================================================================

-----------------------------------------------------------------------
 tchan - 2003-12-09 17:29 GMT 
-----------------------------------------------------------------------
KEEP_SOURCE is ONLY intended for devs that are trying to debug compiling
code.  It was meant to save them the unpack time.  The use of KEEP_SOURCE
in the kernel modules is more of a side benefit for keeping /usr/src/linux
symlink alive.  I disagree that module patches should be applied in
PRE_BUILD all the time.  Too many modules have patches already, adding an
extraneous PRE_BUILD script for all those modules just to have ONE
patch_it line is bloat.

-----------------------------------------------------------------------
 hardkrash - 2003-12-09 21:25 GMT 
-----------------------------------------------------------------------
perhaps we need to have a patch form for our sources
in DETAILS

PATCHES="$SOURCE2:1,$SOURCE3:4"

for lists of patches
PATCHES=`cat filename`

where in prebuild patches get applied
and the patch algorithem looks like this

cd $SOURCE_DIRECTORY
IFS=","
for PATCHnLEVEL in $PATCHES; do
 IFS=":"
 patch_it $SOURCE_CACHE/$PATCHnLEVEL
done

IFS=$STANDARD_IFS

or something like that

this way patches are applied and then for the modules that have build
files only to apply patches we can get rid of them too, less bloat