submission shadow.patch was rejected

[Richard B. Pyne]

As I pointed out, and included, it had previously been posted to the 
lunar at lunar-linux.org list.

On 7/11/2011 11:48 PM, Auke Kok wrote:
>
> mailing me personally is not enough, you need to discuss the rejection 
> on the mailinglist, as I requested in the rejection: post to the list 
> or do a bugreport.
>
> also, if you do send a fix, and it's related to a previous thread, it 
> would help if you would reference the thread in the submission.
>
> Auke
>
>
>
> On 07/11/2011 10:21 PM, Richard B. Pyne wrote:
>> Without this patch, which does nothing more than restore files removed
>> in a prior update, updating shadow on a system without Linux-PAM leaves
>> the system without root access other than booting in single user mode. I
>> reported this problem on the lunar at lunar-linux.org list on july 1, 2011
>> and reported the solution on 3 July 2011.
>>
>> As it is, the shadow module is seriously broken, leaving systems
>> completely unable to perform root functions because it removes system
>> files that should not be removed. All my patch does is to restore files
>> that were removed from the module by a previous update, which update was
>> not properly regression tested or this problem would never have 
>> occurred.
>>
>> The thread reporting the problem and the solution is included below.
>>
>> --Richard
>>
>> On 7/11/2011 6:22 PM, sofar at lunar-linux.org wrote:
>>> Hi,
>>>
>>> This mail is to notify you that your submission "shadow.patch" was
>>> rejected
>>>
>>> Most likely this is because:
>>>
>>> "Patch was rejected during review"
>>>
>>> Thank you for submitting updates to us!
>>>
>>> This needs a lunar-dev post explaining, or at least a bugreport.
>>
>>
>>
>>
>> On 7/3/2011 11:03 AM, Richard B. Pyne wrote:
>>>
>>>
>>> On 7/1/2011 3:14 PM, Stefan Wold wrote:
>>>>
>>>> On Fri, 2011-07-01 at 13:12 -0600, Richard B. Pyne wrote:
>>>>> I started updating my lunar based server this morning and now cannot
>>>>> log
>>>>> get to being root except from booting in single user mode.
>>>>>
>>>> Check your logs! They should at least give you an indication what is
>>>> wrong. My hunch is that you might have had a modified pam file
>>>> in /etc/pam.d, if that is the case shadow nor Linux-PAM will update 
>>>> that
>>>> file. Does lvu install shadow and lvu install Linux-PAM list any files
>>>> in /etc/pam.d?
>>>>
>>>> If they do, please tell is which ones. If it doesn't that is your 
>>>> issue.
>>>> You need to manually replace the pam.d files or remove them
>>>> from /etc/pam.d and reinstall shadow and Linux-PAM.
>>>>
>>> The first thing do after a new lunar install is to remove Linux-PAM.
>>> while the /etc/pam.d directory does exist, it is empty.
>>> What I was able to discover is that the /etc/login.defs files was
>>> missing. Simply creating an empty /etc/login.defs files has cured the
>>> problem. Something in the update of shadow deleted the file.
>>>
>> I did a little digging and found that it also removed the
>> /etc/login.access and /etc/limits files. It appears that the cause of
>> these files being removed is that even though the build script contains
>> the lines:
>>
>> [ -e /etc/limits ] || install -m 0644 etc/limits /etc/
>> [ -e /etc/login.access ] || install -m 0644 etc/login.access /etc/
>> [ -e /etc/login.defs ] || install -m 0644 etc/login.defs /etc/
>>
>> the files have been removed from the module and therefore do not get
>> re-installed.
>>
>>
>