Suggestion: Bugfix for kopete (icq) kdenetwork3 v3.5.4

[Dennis Veatch]

On Tuesday 12 September 2006 11:45, Bernd Kosmahl wrote:
> hi,
> kopete-users using icq can't connect to icq-servers because of a small
> bug. The icq-server refuses connection and claims that the installed
> icq is to old. You can read more about it here
> http://www.kde-forum.org/artikel/15097/Kopete-ICQ-protocol-changed-again-so
>lved.html
>
> There is a patch avaible fixing the version-issue here
> http://bugs.kde.org/attachment.cgi?id=17185&action=view
>
> Index: kopete/protocols/oscar/liboscar/oscartypes.h
> ===================================================================
> --- kopete/protocols/oscar/liboscar/oscartypes.h	(revision 568242)
> +++ kopete/protocols/oscar/liboscar/oscartypes.h	(working copy)
> @@ -239,7 +239,7 @@
>  	const WORD ICQ_MAJOR 			= 0x0014;
>  	const WORD ICQ_MINOR 			= 0x0034;
>  	const WORD ICQ_POINT 			= 0x0000;
> -	const WORD ICQ_BUILD 			= 0x0A0F;
> +	const WORD ICQ_BUILD 			= 0x0BB8;
>  	const char ICQ_OTHER[] 			= { 0x00, 0x00, 0x04, 0x3d };
>  	const char ICQ_COUNTRY[] 		= "us";
>  	const char ICQ_LANG[] 			= "en";
>
> I tried it and now it works fine again. Perhaps somebody can add this as
> a patch for kdenetwork3 3.5.4?

The patch wasn't really needed as a simple sedit in the BUILD can replace the 
offending line. Anyway, committed and thanks,

-- 
You can tuna piano but you can't tune a fish.