Module Submission - pwim

[sofar]

On Fri, 17 Mar 2006 23:03:18 -0500, ccs4ever <ccs4ever at gmail.com> wrote:
> I am the developer of pwim and would like to see it added to the
> moonbase because I believe it can help others as much as it has helped
> me.
> PS. I don't know much about module internals, and would appreciate any
> corrections and explanations as to how the individual internal
> functions function, as that is not well documented. Thank you

okay - some comments:

> --- pwim/BUILD	1969-12-31 19:00:00.000000000 -0500
> +++ pwim/BUILD	2006-02-01 01:31:07.000000000 -0500
> @@ -0,0 +1,10 @@
> +(
> +	cd $SOURCE_DIRECTORY &&

not needed, PWD is by default $SOURCE_DIRECTORY
> +	prepare_install &&
> +	./install*

you should really write a proper Makefile in your app! ;^)

> +) > $C_FIFO 2>&1


> +SOURCE_URL[0]=http://osdn.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[1]=http://jaist.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[2]=http://citkit.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[3]=http://surfnet.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[4]=http://puzzle.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[5]=http://ovh.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[6]=http://internap.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[7]=http://easynews.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[8]=http://peterhost.dl.sourceforge.net/sourceforge/$MODULE/
> +SOURCE_URL[9]=http://voxrox.dl.sourceforge.net/sourceforge/$MODULE/

all these lines can be replaced by:

SOURCE_URL=$SFORGE_URL/$MODULE/

> +WEB_SITE=http://pwim.sourceforge.net
> +MAINTAINER=ccs4ever at gmail.com
> +ENTERED=20060201
> +UPDATED=20060201
> +SHORT="Pwim lets you Play What You(I) Mean(cc)"

you shouldn't put special characters in here (especially brackets) just to be sure. Also, and I cannot say this enough - the SHORT description should NOT contain the name of your app - the user KNOWS the name already ;^).

examples:

Bad: SHORT="Libxml2 is an XML library version 2" (says nothing)
Good: SHORT="Provides Extensible Markup Language functionality to gnome2 applications" (says a LOT) 

> +cat << EOF
> +Pwim utilizes python to find through a given set of directories the
> string, or strings, that you meant to play. For example, 'pwim foo
> bar' will yield you 'fooity baria.wmv' to be played with the media
> player of your choice.
> +EOF
> --- pwim/PRE_BUILD	1969-12-31 19:00:00.000000000 -0500
> +++ pwim/PRE_BUILD	2006-01-19 20:13:15.000000000 -0500
> @@ -0,0 +1 @@
> +default_pre_build

this is redundant, remove the entire file!


hth

Auke