Module submission - Wine-cvs - comments

[sofar]

On Fri, 03 Mar 2006 10:37:00 +0000, jean.bruenn at ip-minds.de wrote:
> 
> module name       : Wine-cvs

the logic below is REALLY confusing:

+mquery WIN64 "build a Win64 emulator on AMD64 (won't run Win32 binaries) NOT
RECOMMENDED?" n &&
+mquery WIN16 "do not include Win16 support?" n &&

I would make this:

+mquery WIN64 "Build a 64bit emulator on x86_64 (will not run W32 binaries - not recoomended)?" n &&
+mquery WIN16 "Include Win16 support?" n &&

Note that I removed the negation in the second line.

(note also that the arch for 64-bit extensions is x86_64, not AMD64, as the resulting code will run fine on ALL 64-bit extension capable cpu's.)

+if [ "$WIN64" == "y" ]; then
+	OPTS="$OPTS --enable-win64"
+fi &&
+if [ "$WIN16" == "n" ]; then
+	OPTS="$OPTS --disable-win16"
+fi &&

flip 'y' to 'n' here and it starts to make sense

Auke