[Lunar-commits] <moonbase> vlc: Adjusting BUILD per changes to build.lunar. Fleshed out the DEPENDS some more.

[Dennis Veatch]

On Thursday, June 16, 2011 6:42:45 PM Auke Kok wrote:
> On 06/16/2011 02:56 PM, Dennis `stumbles` Veatch wrote:
> > commit bf16e4815d63b5677b485d9b6717ba863d54d841
> > Author: Dennis `stumbles` Veatch<stumbles at lunar-linux.org>
> > Date:   Thu Jun 16 17:56:12 2011 -0400
> > 
> >      vlc: Adjusting BUILD per changes to build.lunar. Fleshed out the
> >      DEPENDS some more.
> >      
> >      Some of these such as opencv default to off and for this one say no
> >      for now as it causes the make to fail.
> 
> don't do all of this just yet, we need to do several things before we
> can do all of these changes to modules, and then we should do all of
> moonbase at once instead.

Sorry. Thought we were all set.

> 
> see below for comments:
> > ---
> > 
> >   video/vlc/BUILD   |   22 ++++---
> >   video/vlc/DEPENDS |  182
> >   +++++++++++++++++------------------------------------ 2 files changed,
> >   72 insertions(+), 132 deletions(-)
> > 
> > diff --git a/video/vlc/BUILD b/video/vlc/BUILD
> > index 11b5fbc..201c174 100644
> > --- a/video/vlc/BUILD
> > +++ b/video/vlc/BUILD
> > @@ -1,30 +1,34 @@
> > 
> >   (
> > 
> > +  if in_depends $MOULDE live555; then
> > +    OPTS+=" -with-live555-tree=/usr/lib/live"
> > +  fi
> > +
> > 
> >   # Fixes a make failure if you say yes to libupnp.
> >   
> >     if in_depends $MODULE libupnp; then
> >     
> >       sed -i "27i #include<assert.h>"
> >       modules/services_discovery/upnp_intel.cpp
> > 
> > -  fi&&
> > +  fi
> 
> keep these in. neither lunar has the code to enforce `set -e`, and
> theedge has not been 'forced as an update', so it's 100% likely that
> people will not even have the needed code for these changes
> 
> > -)>  $C_FIFO 2>&1
> > +)
> 
> you can remove the ) here entirely around the block, but again, don't do
> this just yet.

OK.


> 
> well, this is a major improvement, crazy long list though :)
> 
> still missing a few --disable/--without flags though.
> 
> Auke
> _______________________________________________


Yes it is crazy long. The reason some do not have a --disable/--without; they 
default to disable/without. Unless you are saying you want those regardless of 
their default status.

-- 
Dennis `stumbles` Veatch
Lunar Linux Developer
http://www.lunar-linux.org/