[Lunar-commits] <moonbase> gtk+-2: DEPENDS update (libXcomposite is ...

[Auke Kok]

On 06/14/2011 11:16 AM, Christian Krause wrote:
> commit 4d3a997e346a9425e9f8106de5562dd06f94b6a9
> Author: Christian Krause<wookietreiber at lunar-linux.org>
> Date:   Tue Jun 14 20:16:09 2011 +0200
>
>      gtk+-2: DEPENDS update (libXcomposite is ...
>
>      rather the right optional dependency for X gdk-target than libX11
>      and since libXcomposite depends on libX11 this should be working, too,
>      but libXcomposite is definetely NOT a required dependency!
> ---
>   graphics/gtk+-2/DEPENDS |    5 ++---
>   1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/graphics/gtk+-2/DEPENDS b/graphics/gtk+-2/DEPENDS
> index 46b421c..259031d 100644
> --- a/graphics/gtk+-2/DEPENDS
> +++ b/graphics/gtk+-2/DEPENDS
> @@ -2,10 +2,9 @@ depends  gdk-pixbuf
>   depends  atk
>   depends  pango
>   depends  cairo
> -depends  libXcomposite
>
> -optional_depends "libX11"   "" "" "for X11 as gdk-target"
> -optional_depends "DirectFB" "" "" "for DirectFB as gdk-target"
> +optional_depends "libXcomposite" "" "" "for X as gdk-target"
> +optional_depends "DirectFB"      "" "" "for DirectFB as gdk-target"

please stop doing this

if you use optional_depends, you MUST provide the --disable-flags

adding new entries without --disable-flags means that people don't have 
a choice, and they will always get "foo" if it's installed, no matter 
what they would answer to the optional_depends or not.

this type of 'thoughtless' coding is all over moonbase, but it's no 
reason to add more, especially for something stupid like this, where 99% 
of people will want libXcomposite anyway (until wayland, that is)

Auke