submission hex-a-hop-git.patch was rejected
engelsman at lunar-linux.org
engelsman at lunar-linux.org
Sat Aug 13 20:07:49 CEST 2011
Hi Aaron,
This mail is to notify you that your submission "hex-a-hop-git.patch"
was rejected during review. It would be really helpful if you could
resubmit it after addressing the problems outlined below:
DETAILS:
1. where possible, the module should have the same basename as the
package, so the first thing to do is rename it to 'hexahop-git'
2. as the source comes from a live git repo rather than a tarball
snapshot, the version should be set to 'beta'
3. the rest of DETAILS looks basically OK
DEPENDS:
1. modules which need to be already installed for hexahop to build
or run should be declared using 'depends' with the module name
as the only parameter
2. modules which allow extra features but which are not really
needed, should be declared using 'optional_depends' with the
module name as a parameter, then three strings giving the
option to be passed to the build if this module is enabled,
if it is disabled, and a message that appears during 'lin'
BUILD:
1. each command line within the BUILD should be separated from
the next with '&&' at the end of the line (and no whitespace)
so that if it fails, the rest of the BUILD is skipped.
2. you shouldn't need to echo or call 'default_cvs_game_config'
3. you should maybe use 'default_game_build' instead of 'default_name'
4. that might simplify your autogen.sh parameters as well
The wiki contains a lot of information about building modules, but it
is not 100% complete, so sometimes you need to see how others do it.
You might want to look at the wesnoth and warzone2010 configurations
and http://wiki.lunar-linux.org/index.php/Module_Basics
Thank you for submitting updates to us!
Cheers
engelsman
PS. Yes, we should probably have a zbeta/games section too
More information about the Lunar-dev
mailing list