default_cmake

[Dennis Veatch]

On Monday 23 March 2009 11:07:06 am Auke Kok wrote:
> Dennis Veatch wrote:
> > On Monday 23 March 2009 8:39:32 am Dennis Veatch wrote:
> >> On Sunday 22 March 2009 11:01:05 pm Dennis Veatch wrote:
> >>> On Sunday 22 March 2009 8:30:35 am Dennis Veatch wrote:
> >>>> Been playing around with a new default_cmake function for build.lunar.
> >>>> There isn't all that much to it really. Just using the the cmake
> >>>> entries in the kde4 BUILD modules and poking that into default_cmake.
> >>>> It will work for those cmake+modules that use " cmake ." and "cmake
> >>>> $SOURCE_DIRECTORY". I have tried with; kdelibs4, kdebindings4,
> >>>> avidemux, telepathy-qt, and others. If you want to give it a spin here
> >>>> it is.
> >>>
> >>> Here is a slight change to the last patch. All it does is add a
> >>> default_cmake_build to include default_make. Have not found a cmake
> >>> dependent module that has failed to build.
> >>>
> >>> One thing I would like to incorporate is the ability of build.lunar (or
> >>> appropriate script) to, in a sane way, detect if it should use
> >>> default_build or default_cmake_build.
> >>>
> >>> Any thoughts about about how to do that is appreciated. One thought was
> >>> to do something like PSAFE such as CMAKE=yes. Not real fond of that
> >>> idea, nor looked at the logic to make it happen.
> >>>
> >>> Another thought. Alter the run_build function starting on line 396. The
> >>> idea here is to test for the presence of CMakeLists.txt, if there, then
> >>> default_cmake_build, else default_build. AFAICT from the cmake
> >>> documentation, any project using cmake, will at the minimum have
> >>> CMakeLists.txt in its top level directory.
> >>>
> >>> Anyway, that's about as far as the gray matter has gotten. So feel free
> >>> to critique on any level.
> >>
> >> Here is a third installment. Just a simple elif test for CMakeLists.txt,
> >> if ! then default_build. It works with a number of modules that do not
> >> have a BUILD, and those with BUILD+cmake.  Not seen any issues as yet.
> >> Anyway, here it is.
> >
> > Ignore that last patch, use this one.
>
> don't like this patch - it will try to do a cmake build before a GNU
> make build, which I would prefer to try first.
>
>

I take it you refer to the change in the run_build function. You are right, 
only if there is a CMakeLists.txt file. That seemed the simplest way to 
determine which default build to run. ATM, I don't see another way to 
determine how to detect when either default build should be run. I am trying 
to keep this on a kiss level, so If you have something clever in mind please 
point me in that direction.

Unless you are referring to the default_cmake_build function, where it runs 
the default_cmake function. Maybe that really should be called 
default_cmake_config, since it is doing a similar thing the default_config 
does.

-- 
You can tuna piano but you can't tune a fish.

http://www.lunar-linux.org/
It's worth the spin.