[Lunar-commits] <moonbase> physfs: slight alteration to BUILD.

[Dennis Veatch]

On Saturday 03 January 2009 5:18:11 pm Zbigniew Luszpinski wrote:
> > commit 65f224c1d3b899b92e43f5066a1253f0f31cf351
snip
> > +
> > +# Else the make fails on ccplus errors.
> > +  unset CXXFLAGS &&
> > +# end
snip
>
> Ugly hack.
> Dennis, it would be better if you just sed on fly breaking c++ flag from
> CXXFLAGS instead of dropping whole CXXFLAGS. Please post your CXXFLAGS (and
> error you get if you still have log).
>
> have a nice day,
> Zbigniew 'zbiggy' Luszpinski
> _______________________________________________

I don't agree. But, if you think that is ugly, then take a gander at the 
audacity BUILD, and there are many others using unset.

The BUILD was failing on;

[100%] Building CXX object CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o
cc1plus: warnings being treated as errors
In file included from /usr/include/wx-2.8/wx/wx.h:21,
...
...
...
make[2]: *** [CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o] Error 1
make[1]: *** [CMakeFiles/wxtest_physfs.dir/all] Error 2
make: *** [all] Error 2

and using the default optimizations, with the exception of cpu=athlon64. 

If you know the method telling cmake NOT to treat warnings as errors, then 
feel free to alter the BUILD.