[Lunar-commits] <lunar> Add sanity check: don't allow patch files to be submitted

[Auke Kok]

Duncan Gibson wrote:
>> commit 2d143d693cda096776dd5f51e72bfc11058b0a4f
>> Author: Auke Kok <sofar at foo-projects.org>
>> Date:   Sat Aug 8 18:35:38 2009 -0700
>> ...
>> +    # sanity checks
>> +    lvu diff $1 | diffstat -p0 -l | grep -e '.patch$' -e '.diff$' && (
>> +      echo ""
>> +      echo "Sanity check failed: patch files are not allowed inside
>> moonbase"
>> +      echo "Please submit your patch files to the lunar-dev mailinglist
>> and"
>> +      echo "Wait for one of the developers to upload them to
>> \$PATCH_URL."
>> +      echo "Once that is done you can resubmit using that URL for the
>> patch(es)"
>> +      exit 1
> 
> Once lvu has detected the patch files, wouldn't it be possible for it
> to send the module submission  to the mailing list automatically?

no, since it requires you to modify the submission, and I want people to 
test their modules before they are submitted

> Or has the old mail submission infrastructure been dismantled?

realistically, yes, those bits are dead

Auke