[Lunar-commits] r25168 - moonbase/trunk/graphics/libpng

[Zbigniew Luszpinski]

Sunday 22 of July 2007 14:39:19 Jannis Pohlmann wrote:
> > > +CFLAGS="${CFLAGS//march/mtune}"
> > > +CFLAGS="${CFLAGS//=sse/=387}"
> > > +CFLAGS="${CFLAGS//=387,387/=387}"
> > > +CFLAGS="${CFLAGS//-mmmx/-mno-mmx}"
> > > +CFLAGS="${CFLAGS//-m3dnow/-mno-3dnow}"
> > > +CFLAGS="${CFLAGS//-msse/-mno-sse}"
> > > +CFLAGS="-march=`uname -m` $CFLAGS"
> > > +default_build
> >
> > really, this kind of optimization is silly. did you measure the
> > performance difference? How much is the average user going to benefit
> > from this?
>
> Optimizations just don't belong into the BUILD file, do they? Everyone
> should be free to decide when to use them or not. That's why we have
> the optimizations plugin for 'lunar'.

As everybody sees, this code is deoptimizator because disables use of simd by 
gcc (if it was enabled in cflags). :P
uname -m will neither return something greater than i686 nor activate simd.
I see there is 2:1 for removing build so you are welcome to do it.

Zbigniew