sm-xrender.patch redundant for mozillas: FF, TB, SM ?

Kok, Auke sofar at foo-projects.org
Mon Dec 3 16:37:07 CET 2007


Zbigniew Luszpinski wrote:
> Hi,
> 
> I think the SOURCE2=sm-xrender.patch is redundant for all mozillas (FF, TB, 
> SM). Just look at BUILD script:
> sedit "s/(MOZ_GTK2_LIBS)/(MOZ_GTK2_LIBS) -lX11 -lXrender/" 
> layout/build/Makefile.in &&
> 
> and sm-xrender.patch:
> --- mozilla/layout/build/Makefile.in    2007-01-18 22:50:01.000000000 +0100
> +++ mozilla/layout/build/Makefile.in    2007-01-18 22:53:22.000000000 +0100
> @@ -225,7 +225,7 @@
>  endif
> 
>  ifdef MOZ_ENABLE_GTK2
> -EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) \
> +EXTRA_DSO_LDOPTS += $(MOZ_GTK2_LIBS) -L/usr/X11R6/lib -lXrender -lX11 \
>                     $(NULL)
>  endif
> 
> I think sm-xrender.patch can be removed from all modules using it:
> seamonkey
> firefox
> thunderbird
> and of course PATCH_URL server because nothing else use it.
> -L/usr/X11R6/lib is not needed as mozilla autodetects this path.

good catch... I prefer sedits for this small kind of stuff anyway!

Please, drop the unused patch ;)

Auke


More information about the Lunar-dev mailing list