Fw: Re: ppp mppe patch

[Moritz Heiber]

Here are the instruction to fix the mppe patch, Bug #129. Somebody
please correct the patch and upload it to $PATCH_URL. I do not have the
time currently.

Thanks.

Moritz

Begin forwarded message:

Date: Sun, 03 Sep 2006 23:11:16 +0200
From: Jan Just Keijser <janjust at nikhef.nl>
To: Moritz Heiber <moe at lunar-linux.org>
Subject: Re: ppp mppe patch


Hi Moritz,

nice catch! I hadn't tested compiling the patch against openssl 0.9.8 
yet. Seems that they've changed their include-file-inclusion-order 
slightly (file A including file B including file C etc). To fix it, 
please add a line to eap-tls.h:

     37 #include <openssl/ssl.h>
     38 #include <openssl/bio.h>
     39 #include <openssl/md5.h>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

line 39 is new. With this line added , the patch compiles again. I will 
post an updated patch as soon as I have run some tests.

thx and nice to hear somebody is trying to *use* my patch ;-)

cheers,

Jan Just Keijser


Moritz Heiber wrote:
> Hello,
>
> I'm trying to apply your mppe patch to ppp 2.4.4 .. unfortunately, I
> cannot get ppp to compile with your patch being applied. It spits out
> the following error message:
>
>
> gcc -O2 -pipe -Wall -g -I/usr/kerberos/include -DHAVE_PATHS_H
> -DIPX_CHANGE -DHAVE_MMAP -I../include '-DDESTDIR="/usr"' -DCHAPMS=1
> -DMPPE=1 -DHAS_SHADOW -DHAVE_CRYPT_H=1 -DUSE_CRYPT=1 -DHAVE_MULTILINK
> -DUSE_TDB=1 -DPLUGIN -DMAXOCTETS   -c -o eap-tls.o eap-tls.c eap.c:
> In function `eap_request': eap.c:1552: error: `MD5_CTX' undeclared
> (first use in this function) eap.c:1552: error: (Each undeclared
> identifier is reported only once eap.c:1552: error: for each function
> it appears in.) eap.c:1552: error: syntax error before "mdContext"
> eap.c:1681: warning: implicit declaration of function `MD5_Init'
> eap.c:1681: error: `mdContext' undeclared (first use in this
> function) eap.c:1683: warning: implicit declaration of function
> `MD5_Update' eap.c:1687: warning: implicit declaration of function
> `MD5_Final' eap.c: In function `eap_response': eap.c:2046: error:
> `MD5_CTX' undeclared (first use in this function) eap.c:2046: error:
> syntax error before "mdContext" eap.c:2248: error: `mdContext'
> undeclared (first use in this function) gcc -O2 -pipe -Wall -g
> -I/usr/kerberos/include -DHAVE_PATHS_H -DIPX_CHANGE -DHAVE_MMAP
> -I../include '-DDESTDIR="/usr"' -DCHAPMS=1 -DMPPE=1 -DHAS_SHADOW
> -DHAVE_CRYPT_H=1 -DUSE_CRYPT=1 -DHAVE_MULTILINK -DUSE_TDB=1 -DPLUGIN
> -DMAXOCTETS   -c -o md4.o md4.c make[1]: *** [eap.o] Error 1 make[1]:
> *** Waiting for unfinished jobs.... make[1]: Leaving directory
> `/usr/src/ppp-2.4.4/pppd' make: *** [all] Error 2
>
> It doesn't matter which one of the patches I try (the regular one or
> the no_ifdefs) .. it always fails at the same cornerstone.
>
> I'm using a 2.6.17.x kernel on a pretty casual configuration. Openssl
> 0.98a and curl 7.15.5 are installed as mentioned in your addition to
> the eaptls README.
>
> Any hints or ideas? Thanks for your time and your concern.
>
> Regards,
>
> Moritz Heiber
>