[Lunar-commits] r17880 - moonbase/trunk/libs/glibc

[Jaime Buffery]

Hello, 

Seeing the commit:

> Modified:
>    moonbase/trunk/libs/glibc/BUILD.sparc64
> Log:
> Added the changes sofar made to BUILD to try and keep BUILD.sparc64 in some
> kind of sync.
> 
> 
> Modified: moonbase/trunk/libs/glibc/BUILD.sparc64
> ===================================================================
> --- moonbase/trunk/libs/glibc/BUILD.sparc64	2006-01-02 04:15:46 UTC (rev 17879)
> +++ moonbase/trunk/libs/glibc/BUILD.sparc64	2006-01-02 04:23:44 UTC (rev 17880)
> @@ -23,16 +23,15 @@
>    cd $INSTALL_ROOT
>  
>    if module_installed kernel-headers-2.6 ; then
> -     KERNEL_HEADERS="/usr/include"
> +     OPTS="$OPTS --with-headers=/usr/include"
>    else
> -     KERNEL_HEADERS="/usr/src/linux/include"
> +     OPTS="$OPTS --with-headers=/usr/src/linux/include"
>    fi

If kernel-headers-2.6 is currently not used for sparc (at least not yet) I know 
this will be harmless for that arch. But in k-h-2.6's DETAILS' file:

      PKG=2.6.12.0
  VERSION=${PKG}-i386

because in its BUILD:

  # asm is a special case, since it is arch specific
    mv asm-i386 asm &&

I guess we could create dynamically VERSION or use the coretools' arch type 
(${PLATFORM}?), and use it in the BUILD, as what we currently have is 

    mv asm-$VERSION asm &&

The other solution is to rewrite the whole lot, but that seems a bit pointless, 
if the arch is well set. I'm not sure how to leave it well set, otherwise I 
would have done it already.

For sparc, in linux-libc-headers, kernel-headers-2.6's source files:

/usr/src/linux-libc-headers-2.6.12.0/include# ls -ld *sparc*
drwxr-xr-x 2 30020 30000 3352 Jul  6 19:01 asm-sparc/
drwxr-xr-x 2 30020 30000 3160 Jul  6 19:01 asm-sparc64/

The same logic can and should be applied to x64's port:

/usr/src/linux-libc-headers-2.6.12.0/include# ls -ld *ia64 *_64
drwxr-xr-x 3 30020 30000 2440 Jul  6 19:01 asm-ia64/
drwxr-xr-x 2 30020 30000 2672 Jul  6 19:01 asm-x86_64/

Ciao,
Jaime.