[PATCH] patch for lin need_source function

Auke Kok sofar at lunar-linux.org
Tue Apr 13 10:38:34 GMT 2004


Jasper Huijsmans wrote:

> Auke,
>
> This seems to fix the problem with limitless lin's being spawned.
> Doesn't seem to break anything else.
>
> The patch removes the subshell (why was it needed?) and adds some code
> to make the list unique (uniq needs a sorted list, so won't always
> work). Some other thing were changed as well.


I'm having difficulties understanding the patch:

1) the subshell indeed is unneeded

2) the uniq call without sort was deliberate, as the function returns 
items based on build order. During testing I found that some items were 
returned repeatedly, hence the uniq call. adding a 'sort' would perhaps 
reduce the number of duplicates, but it also would distort the order.

3) I haven't had time enough to check out how it really works now, maybe 
because also I don't really yet see how you apparently solved the probel ;^)

I'm considering dumping the "new" method and going back to the old style 
download (ie spool al immediately required modules on start, download 
secondary requirements when needed).


l8r

sofar


More information about the Lunar-dev mailing list