[Lunar-commits] <moonbase> aliases: Adding lighttpd.

[Auke Kok]

On 02/24/2012 05:19 PM, Dennis Veatch wrote:
> On 02/24/2012 08:09 PM, Auke Kok wrote:
>> On 02/24/2012 03:12 AM, Dennis `stumbles` Veatch wrote:
>>> commit 6511413a8006c19778d7d7208f11cd9a0a3dfbe3
>>> Author: Dennis `stumbles` Veatch<stumbles at lunar-linux.org>
>>> Date: Fri Feb 24 06:12:28 2012 -0500
>>>
>>> aliases: Adding lighttpd.
>>> ---
>>> aliases | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/aliases b/aliases
>>> index f21fb50..4a2a72b 100644
>>> --- a/aliases
>>> +++ b/aliases
>>> @@ -1,4 +1,4 @@
>>> -%APACHE:httpd apache apache-mod_ssl
>>> +%APACHE:httpd apache apache-mod_ssl lighttpd
>>
>> what's the rationale behind adding lighthttpd?
>>
>> the commit message should explain "why", not just "what" is changed,
>> since that is obviously self-explanatory.
>
> I thought it being a web server would have been obvious.

no, and it's entirely not the right reason to add something to an %alias 
either.

%aliases are used in depenency tracking. So, if something requires a 
$service that provides a specific API, we can have multiple packages 
provide that by being "equivalent".

What you've done is promoted lighthttpd to be equivalent to apache, 
apache2. But nothing in your commit says that you've tested everything 
that requires %APACHE to work with lighthttpd.

$ grep -rl %APACHE *
compilers/aubit4glsrc/DEPENDS
web/bitweaver/DEPENDS
web/drupal/DEPENDS
web/htdig/DEPENDS
web/mod_scgi/DEPENDS

So, did you test these packages to work with lighthttpd as "%APACHE" ?

Auke