[Lunar-commits] <moonbase> amd-ucode: updated to 2012-01-17

[Auke Kok]

On 03/14/2012 03:41 PM, Zbigniew Luszpinski wrote:
> commit ebec88418f9ee3e4430c7fd6271d21ef82c0af57
> Author: Zbigniew Luszpinski<zbiggy at lunar-linux.org>
> Date:   Wed Mar 14 23:41:43 2012 +0100
>
>      amd-ucode: updated to 2012-01-17
> ---
>   utils/amd-ucode/BUILD   |   11 +++++++++--
>   utils/amd-ucode/DETAILS |    6 +++---
>   2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/utils/amd-ucode/BUILD b/utils/amd-ucode/BUILD
> index 1b00727..b32a9c8 100644
> --- a/utils/amd-ucode/BUILD
> +++ b/utils/amd-ucode/BUILD
> @@ -1,7 +1,14 @@
>   (
>
> +   rm -f microcode_amd_solaris.bin*&&
> +   if [ ! -h /lib/firmware ]; then
> +      mkdir -p /usr/lib/firmware
> +      cp -a /lib/firmware/* /usr/lib/firmware/
> +      rm -rf /lib/firmware
> +      ln -sf /usr/lib/firmware /lib/firmware
> +   fi&&

no, this is wrong, you should instead fix udev to use:

   --with-firmware-path=/lib/firmware

and then you can just drop the firmware in /lib/firmware.

the change you did here breaks linux-firmware.

the correct place for firmware is *still* /lib/firmware, and not 
/usr/lib/firmware.

Auke