[Lunar-commits] <moonbase> hplip: set parport & fax on by default

[Paul Bredbury]

commit 922fe435c01dc6a187138b5fad09cf6db6502d85
Author: Paul Bredbury <brebs at lunar-linux.org>
Date:   Sun Mar 6 15:50:51 2011 +0700

    hplip: set parport & fax on by default
    
    There ought to be a good, stated reason for crippling a package by
    default. I see no reason, or advantage, here.
    
    The question should never be "Do you want to disable X?" - it's bad
    user-interface design.
---
 printer/hplip/BUILD     |    2 +-
 printer/hplip/CONFIGURE |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/printer/hplip/BUILD b/printer/hplip/BUILD
index 807d775..f8b7090 100644
--- a/printer/hplip/BUILD
+++ b/printer/hplip/BUILD
@@ -4,7 +4,7 @@
      . /etc/profile.d/qt4.rc
   fi &&
 
-  if [[ "$PP" == "y" ]] ; then
+  if [[ "$PARPORT" == "n" ]] ; then
     OPTS+=" --disable-pp-build"
   fi &&
 
diff --git a/printer/hplip/CONFIGURE b/printer/hplip/CONFIGURE
index 25fbb02..dcebbb9 100644
--- a/printer/hplip/CONFIGURE
+++ b/printer/hplip/CONFIGURE
@@ -1,3 +1,3 @@
-mquery PP "Disable HP parallel port printing support (if your HP printer is USB only)?" y
-mquery FAX "Enable builtin fax in your HP printer?" n
+mquery PARPORT "Enable printing via parallel port (not needed for USB printers)?" y
+mquery FAX "Enable built-in fax in your HP printer?" y
 mquery FOOMATIC "Install foomatic ppd's (required for PSC and Photosmart printers)?" y "--enable-foomatic-ppd-install --enable-foomatic-rip-hplip-install"