[Lunar-bugs] [Lunar Linux 0000264]: lin sometimes reports invalid module names only after dependency resolution

[Lunar bug reports list]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.lunar-linux.org/view.php?id=264 
====================================================================== 
Reported By:                ToxicFrog
Assigned To:                sofar
====================================================================== 
Project:                    Lunar Linux
Issue ID:                   264
Category:                   lunar
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Moonbase Version:           20060624.20 
Core Tools:                 Lunar 
Core Tools Version:         20060623 
====================================================================== 
Date Submitted:             06-26-2007 01:53 CEST
Last Modified:              07-01-2007 05:42 CEST
====================================================================== 
Summary:                    lin sometimes reports invalid module names only
after dependency resolution
Description: 
When linning something, if one of the modules given does not exist, it will
report this (and exit) only after doing dependency resolution for all
modules preceding it on the command line. For most things, this is largely
a nonissue, but if you do something like:
# lin XOrg7 xawtb
It will spend half an hour doing dependencies for XOrg7, and only
afterwards say "unable to find module xawtb".

Possible fix: verify the existence of all modules specified on the command
line before proceeding to dependency resolution.
====================================================================== 

---------------------------------------------------------------------- 
 ToxicFrog - 06-26-07 02:33  
---------------------------------------------------------------------- 
Uploaded a diff showing a simple implementation of the suggested fix. 

---------------------------------------------------------------------- 
 sofar - 06-29-07 21:25  
---------------------------------------------------------------------- 
patch is wrong: it runs run_details unsecured (will cause namespace
pollution)

1) run_details is slow, using find_section would be preferred
2) non-finding modules now becomes fatal, lunar should ignore the mistake
and try to continue 

---------------------------------------------------------------------- 
 ToxicFrog - 07-01-07 05:42  
---------------------------------------------------------------------- 
(1) noted, will revise patch with that in mind
(2) this contradicts existing behaviour, which is to fatal if one of the
modules is not found - personally, I feel that attempting to continue is
better, but from a patching standpoint I felt it better to match existing
behaviour as closely as possible. (Indeed, what prompted the creation of
this patch was watching Oculus sit there for half an hour resolving XOrg7,
only to say that it couldn't find "xawtb" and kick me back to the prompt.) 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-26-07 01:53  ToxicFrog      New Issue                                    
06-26-07 01:53  ToxicFrog      Status                   new => assigned     
06-26-07 01:53  ToxicFrog      Assigned To               => sofar           
06-26-07 01:53  ToxicFrog      Moonbase Version          => 20060624.20     
06-26-07 01:53  ToxicFrog      Core Tools                => Lunar           
06-26-07 01:53  ToxicFrog      Core Tools Version        => 20060623        
06-26-07 02:32  ToxicFrog      File Added: lin.patch                        
06-26-07 02:33  ToxicFrog      Note Added: 0000573                          
06-29-07 21:25  sofar          Note Added: 0000574                          
07-01-07 05:42  ToxicFrog      Note Added: 0000575                          
======================================================================