[Lunar-bugs] [bug] fcron: build problem & BUILD never calls prepare_install

[lunar-bugs at lunar-linux.org]

 Project:      lunar-linux
 ID:           
 Version:      <none>
 Component:    moonbase (modules)
 Category:     bug reports
 Priority:     minor
 Assigned to:  sofar
 Reported by:  couannette
 Updated by:   sofar
-Status:       active
+Status:       fixed

Index: BUILD
===================================================================
RCS file: /var/cvs/lunar/moonbase/utils/fcron/BUILD,v
retrieving revision 1.4
diff -u -r1.4 BUILD
--- BUILD       17 Mar 2004 13:13:44 -0000      1.4
+++ BUILD       20 Jan 2005 10:42:46 -0000
@@ -19,7 +19,8 @@
                --with-editor=$EDITOR  &&
   make                                &&
   prepare_install                     &&
-  make    install
+  make    install                     ||
+  exit 1


   if [ -e /etc/init.d/fcron.sh ]; then


*fixed*

sofar



Previous comments:
------------------------------------------------------------------------

Fri, 11/26/2004 - 07:12 : couannette

Is there a regression just lurking around ?
moonbase & theedge as of 25/11


gcc -Os -mcpu=athlon-tbird -march=athlon-tbird -mmmx -m3dnow
-mfpmath=387 -Wall  -DHAVE_CONFIG_H  -I. -I. -o fcron fcron.o subs.o
log.o database.o job.o conf.o  
Preparing to install fcron
Removed module: fcron
echo `fcron -V 2>&1 | grep "^fcron "` > ./script/PREVIOUS_VERSION
./script/user-group fcron fcron 0 .
Checking if group fcron exists ... yes.
Checking if user fcron exists ... yes.

User fcron exists, but is not in the group fcron.
Please set its group to "fcron" (id 12) manually
(or choose another user and/or group).
make: *** [install] Error 1
WARNING: BUILD never calls prepare_install!
The executable fcron does not exist!                                 [
FAILED ]
The executable fcron does not exist!                                 [
FAILED ]
Creating /var/log/lunar/compile/fcron-2.0.2.bz2 
Creating /var/log/lunar/install/fcron-2.0.2
Creating /var/log/lunar/md5sum/fcron-2.0.2
Creating /var/cache/lunar/fcron-2.0.2-i686-pc-linux-gnu.tar.bz2


------------------------------------------------------------------------

Fri, 11/26/2004 - 16:13 : sofar


no biggie for now, please ignore the warning at the moment. THere's
some bash semantics futzing my logic so I'll have to chase it down.

------------------------------------------------------------------------

Thu, 01/20/2005 - 10:33 : Moe

Is this issue fixed?

------------------------------------------------------------------------

Thu, 01/20/2005 - 10:42 : sofar

probably not. What is happening is that the BUILD *fails*, but the error
is not trapped and BUILD continues past the last && command, and finds
another command. This breaks the error-catching chain.

conclusion: BUILD is broken.

-- 
View: http://lunar-linux.org/?q=node/view/574
Edit: http://lunar-linux.org/?q=project/comments/add/574