[Lunar Linux 0000375]: Bash code logic in DEPENDS files

[noreply at bugs.lunar-linux.org]

A BUGNOTE has been added to this bug.
=======================================================================
http://bugs.lunar-linux.org/view_bug_page.php?f_id=0000375
=======================================================================
Reporter:                   elaine
Handler:                    nhudson
=======================================================================
Project:                    Lunar Linux
Bug ID:                     0000375
Category:                   moonbase
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
=======================================================================
Date Submitted:             2003-09-22 14:10 GMT
Last Modified:              2003-10-15 03:49 GMT
=======================================================================
Summary:                    Bash code logic in DEPENDS files
Description: 
The moonbase contains a few modules which use program logic 
or external commands in the DEPENDS files.

While this works, it creates substantial problems with 
automating dependency analysis or reading the dependency
data with anything but bash.

An example:  security/nessus/DEPENDS   
depends  nmap    &&
depends  openssl &&
depends  wget    &&
if  grep  -q  "enable-gtk"  $MODULE_CONFIG;  then
  depends gtk+

Preferred fix:

keep all program logic in the CONFIGURE scripts and restrict DEPENDS files
to depends, optional_depends statements.
=======================================================================

-----------------------------------------------------------------------
 nhudson - 2003-10-15 03:49 GMT 
-----------------------------------------------------------------------
Ok I have been working on this, totem has been fixed.  I removed the login
in the DEPENDS file.  Also I am working on mozilla atm.  With the new moz
version 1.4.1 I took out all login in the DEPENDS file.  It will build by
default with gtk2 and xft support along with a few others.  Although for
now there is some login in the other files like in the BUILD, and
CONFIGURE file.  I hope this is ok and if I understood everything
correctly we were just taking it out of the DEPENDS file right?  Let me
know if I need to take out all other logic in the mozilla module.